ghcr.io only accepts lowercase username

[Louwrensth]

No description provided.

[neutrinoceros]

This seems unnecessary, maybe I'm mistaken ? I expect the owner account should always be exactly "h5py", unless there's a reason to run this workflow from a fork ?

[Louwrensth]

Yep, the latter. I wanted to try and run this from my fork, but it complained:

buildx failed with: ERROR: failed to build: invalid tag "ghcr.io/Louwrensth/musllinux_1_2_x86_64-hdf5": repository name must be lowercase

I'll completely understand if you'd like to decline this PR -- for instance, because you don't like the sad clutter I have added with this PR.

So why this clutter? Just to change case!? Madness.

Because ghcr.io cannot handle their own (github.com) "repository_owner" values? More madness lol.

[neutrinoceros]

No it's fine ! I'm just on the fence these days with the rise of useless LLM-backed "contributions" so I'd rather ask than assume good intentions as I used to do.

More madness lol.

This is Sparta. 🥲

[neutrinoceros]

I may have approved slightly prematurely; I don't think I understand what the commas on this line are for.

[Louwrensth]

Yeah, it looks obscure doesn't it?

It's legit :

${parameter,,pattern}

‘,’ converts matching uppercase letters to lowercase.

... ‘,,’ variants examine all characters in the expanded value and convert each one that matches pattern. If pattern is omitted, it is treated like a ‘?’, which matches every character.

https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html#

[neutrinoceros]

wow, this is indeed obscure. I'll add the link as an inline comment and merge. Thank you !