Merge pull request #19 from buildrun-tech/diario/dia-15

infra(day 15): updates ecs desired count to one

Author: brunograna

.github/actions/frontend-runtime-config/action.yml

@@ -0,0 +1,57 @@
+name: Frontend runtime config
+description: >
+  Lê os outputs do Terraform do ambiente e gera dist/config.js
+  (window.__APP_CONFIG__) para o mesmo dist/ servir dev e prod sem rebuild.
+  Falha se algum valor obrigatório vier vazio/null: sem config.js no bucket o
+  CloudFront devolve index.html (custom_error_response) e o app quebra com SyntaxError.
+  Requer credenciais AWS já configuradas no job e TF_STATE_BUCKET / TF_STATE_REGION no env.
+
+inputs:
+  environment:
+    description: dev | prod
+    required: true
+
+outputs:
+  frontend_bucket_name:
+    value: ${{ steps.tf.outputs.frontend_bucket_name }}
+  cloudfront_distribution_id:
+    value: ${{ steps.tf.outputs.cloudfront_distribution_id }}
+
+runs:
+  using: composite
+  steps:
+    - name: Read Terraform Outputs
+      id: tf
+      uses: ./.github/actions/terraform-outputs
+      with:
+        environment: ${{ inputs.environment }}
+    - name: Generate config.js
+      shell: bash
+      env:
+        API_URL: ${{ steps.tf.outputs.api_url }}
+        COGNITO_AUTHORITY: ${{ steps.tf.outputs.cognito_authority }}
+        COGNITO_CLIENT_ID: ${{ steps.tf.outputs.cognito_client_id }}
+        COGNITO_USER_POOL_ID: ${{ steps.tf.outputs.cognito_user_pool_id }}
+        CLOUDFRONT_DOMAIN: ${{ steps.tf.outputs.cloudfront_domain }}
+        FRONTEND_BUCKET_NAME: ${{ steps.tf.outputs.frontend_bucket_name }}
+        CLOUDFRONT_DISTRIBUTION_ID: ${{ steps.tf.outputs.cloudfront_distribution_id }}
+      run: |
+        set -euo pipefail
+        for key in API_URL COGNITO_AUTHORITY COGNITO_CLIENT_ID COGNITO_USER_POOL_ID CLOUDFRONT_DOMAIN \
+                   FRONTEND_BUCKET_NAME CLOUDFRONT_DISTRIBUTION_ID; do
+          value="${!key}"
+          if [ -z "$value" ] || [ "$value" = "null" ]; then
+            echo "::error::Output do Terraform ausente para $key (ambiente ${{ inputs.environment }})."
+            exit 1
+          fi
+        done
+        # jq -n escapa os valores como JSON válido (JSON é JS válido)
+        json=$(jq -n \
+          --arg apiBaseUrl "$API_URL" \
+          --arg cognitoAuthority "$COGNITO_AUTHORITY" \
+          --arg cognitoClientId "$COGNITO_CLIENT_ID" \
+          --arg cognitoUserPoolId "$COGNITO_USER_POOL_ID" \
+          --arg cognitoRedirectUri "https://$CLOUDFRONT_DOMAIN/" \
+          '$ARGS.named')
+        echo "window.__APP_CONFIG__ = $json" > dist/config.js
+        cat dist/config.js

.github/workflows/frontend.yml

@@ -5,6 +5,7 @@ name: frontend
 # push develop = dev: build, guarda dist/ como artifact (`frontend-dist-<sha>`) + deploy S3/CloudFront.
 # push main    = prod: reusa o dist/ do run de develop pro mesmo sha (sem rebuild) + deploy S3/CloudFront.
 # Bucket/distribuição vêm de `terraform output` (infra/, add-terraform-infra), não de repository variables.
+# Config de runtime (Cognito/API) também: deploy gera dist/config.js por ambiente (frontend-runtime-config).
 
 on:
   workflow_call:
@@ -91,13 +92,18 @@ jobs:
         with:
           role-to-assume: ${{ env.AWS_ROLE_ARN }}
           aws-region: ${{ env.AWS_REGION }}
-      - name: Read Terraform Outputs
+      - name: Generate Runtime Config
         id: tf
-        uses: ./.github/actions/terraform-outputs
+        uses: ./.github/actions/frontend-runtime-config
         with:
           environment: dev
+      # config.js fora do sync: --exclude também protege de --delete, sem janela sem config
       - name: Sync to S3
-        run: aws s3 sync dist "s3://${{ steps.tf.outputs.frontend_bucket_name }}" --delete
+        run: aws s3 sync dist "s3://${{ steps.tf.outputs.frontend_bucket_name }}" --delete --exclude config.js
+      - name: Upload Runtime Config (no-cache)
+        run: |
+          aws s3 cp dist/config.js "s3://${{ steps.tf.outputs.frontend_bucket_name }}/config.js" \
+            --cache-control no-cache --content-type application/javascript
       - name: Invalidate CloudFront Cache
         run: |
           aws cloudfront create-invalidation \
@@ -152,13 +158,18 @@ jobs:
         with:
           role-to-assume: ${{ env.AWS_ROLE_ARN }}
           aws-region: ${{ env.AWS_REGION }}
-      - name: Read Terraform Outputs
+      - name: Generate Runtime Config
         id: tf
-        uses: ./.github/actions/terraform-outputs
+        uses: ./.github/actions/frontend-runtime-config
         with:
           environment: prod
+      # config.js fora do sync: --exclude também protege de --delete, sem janela sem config
       - name: Sync to S3
-        run: aws s3 sync dist "s3://${{ steps.tf.outputs.frontend_bucket_name }}" --delete
+        run: aws s3 sync dist "s3://${{ steps.tf.outputs.frontend_bucket_name }}" --delete --exclude config.js
+      - name: Upload Runtime Config (no-cache)
+        run: |
+          aws s3 cp dist/config.js "s3://${{ steps.tf.outputs.frontend_bucket_name }}/config.js" \
+            --cache-control no-cache --content-type application/javascript
       - name: Invalidate CloudFront Cache
         run: |
           aws cloudfront create-invalidation \

.github/workflows/pipeline.yml

@@ -51,6 +51,7 @@ jobs:
               - '.github/workflows/frontend.yml'
               - '.github/workflows/pipeline.yml'
               - '.github/actions/terraform-outputs/**'
+              - '.github/actions/frontend-runtime-config/**'
 
   infra:
     name: infra

app/frontend/index.html

@@ -15,6 +15,7 @@
       })()
     </script>
     <div id="root"></div>
+    <script src="/config.js"></script>
     <script type="module" src="/src/main.tsx"></script>
   </body>
 </html>

app/frontend/src/api/client.ts

@@ -1,6 +1,7 @@
+import { config } from '../config'
 import type { ApiErrorBody } from './types'
 
-const API_BASE_URL = import.meta.env.VITE_API_BASE_URL
+const API_BASE_URL = config.apiBaseUrl
 
 export class ApiError extends Error {
   status: number

app/frontend/src/auth/directAuth.ts

@@ -4,17 +4,25 @@ import {
   CognitoUserPool,
   CognitoUserSession,
 } from 'amazon-cognito-identity-js'
+import { config } from '../config'
 
 const SESSION_STORAGE_KEY = 'notebooklm.directAuth.session'
 
 // floci não valida o conteúdo do código de confirmação — qualquer valor confirma o usuário
 const DUMMY_CONFIRMATION_CODE = '000000'
 
-const userPool = new CognitoUserPool({
-  UserPoolId: import.meta.env.VITE_COGNITO_USER_POOL_ID,
-  ClientId: import.meta.env.VITE_COGNITO_CLIENT_ID,
-  endpoint: import.meta.env.VITE_COGNITO_ENDPOINT,
-})
+// lazy: construtor lança sem UserPoolId/ClientId — instanciar no import derrubaria o app
+// em ambientes sem direct auth (CloudFront/AWS usa só Hosted UI)
+let userPool: CognitoUserPool | undefined
+
+function getUserPool(): CognitoUserPool {
+  userPool ??= new CognitoUserPool({
+    UserPoolId: config.cognitoUserPoolId,
+    ClientId: config.cognitoClientId,
+    endpoint: import.meta.env.VITE_COGNITO_ENDPOINT,
+  })
+  return userPool
+}
 
 export interface DirectAuthSession {
   accessToken: string
@@ -44,7 +52,7 @@ export function clearStoredSession() {
 }
 
 export function signIn(email: string, password: string): Promise<DirectAuthSession> {
-  const cognitoUser = new CognitoUser({ Username: email, Pool: userPool })
+  const cognitoUser = new CognitoUser({ Username: email, Pool: getUserPool() })
   const authDetails = new AuthenticationDetails({ Username: email, Password: password })
 
   return new Promise((resolve, reject) => {
@@ -61,13 +69,13 @@ export function signIn(email: string, password: string): Promise<DirectAuthSessi
 
 export function signUp(email: string, password: string): Promise<void> {
   return new Promise((resolve, reject) => {
-    userPool.signUp(email, password, [], [], (err) => {
+    getUserPool().signUp(email, password, [], [], (err) => {
       if (err) {
         reject(err)
         return
       }
 
-      const cognitoUser = new CognitoUser({ Username: email, Pool: userPool })
+      const cognitoUser = new CognitoUser({ Username: email, Pool: getUserPool() })
       cognitoUser.confirmRegistration(DUMMY_CONFIRMATION_CODE, true, (confirmErr) => {
         if (confirmErr) {
           reject(confirmErr)

app/frontend/src/auth/oidcConfig.ts

@@ -1,9 +1,10 @@
 import type { AuthProviderProps } from 'react-oidc-context'
+import { config } from '../config'
 
 export const oidcConfig: AuthProviderProps = {
-  authority: import.meta.env.VITE_COGNITO_AUTHORITY,
-  client_id: import.meta.env.VITE_COGNITO_CLIENT_ID,
-  redirect_uri: import.meta.env.VITE_COGNITO_REDIRECT_URI,
+  authority: config.cognitoAuthority,
+  client_id: config.cognitoClientId,
+  redirect_uri: config.cognitoRedirectUri,
   response_type: 'code',
   scope: 'openid email profile',
   onSigninCallback: () => {

app/frontend/src/config.ts

@@ -0,0 +1,25 @@
+// window.__APP_CONFIG__ vem de /config.js, gerado no deploy a partir dos outputs do Terraform
+// (mesmo dist/ serve dev e prod). Sem ele (dev local, e2e), cai no .env via import.meta.env.
+interface AppConfig {
+  apiBaseUrl: string
+  cognitoAuthority: string
+  cognitoClientId: string
+  cognitoUserPoolId: string
+  cognitoRedirectUri: string
+}
+
+declare global {
+  interface Window {
+    __APP_CONFIG__?: Partial<AppConfig>
+  }
+}
+
+const runtime = window.__APP_CONFIG__ ?? {}
+
+export const config: AppConfig = {
+  apiBaseUrl: runtime.apiBaseUrl ?? import.meta.env.VITE_API_BASE_URL,
+  cognitoAuthority: runtime.cognitoAuthority ?? import.meta.env.VITE_COGNITO_AUTHORITY,
+  cognitoClientId: runtime.cognitoClientId ?? import.meta.env.VITE_COGNITO_CLIENT_ID,
+  cognitoUserPoolId: runtime.cognitoUserPoolId ?? import.meta.env.VITE_COGNITO_USER_POOL_ID,
+  cognitoRedirectUri: runtime.cognitoRedirectUri ?? import.meta.env.VITE_COGNITO_REDIRECT_URI,
+}

app/frontend/src/pages/WorkspacePage.tsx

@@ -15,6 +15,7 @@ import Button from '../components/ui/Button'
 import Input from '../components/ui/Input'
 import Card from '../components/ui/Card'
 import { ApiError } from '../api/client'
+import { config } from '../config'
 import { IconArrowLeft, IconFile, IconPlus, IconSend, IconSpinner, IconTrash, IconUpload } from '../components/icons'
 
 const PENDING_STATUSES = new Set(['PENDING', 'PROCESSING'])
@@ -24,7 +25,7 @@ interface ChatMessage extends ConversationMessage {
   failed?: boolean
 }
 
-const API_BASE_URL = import.meta.env.VITE_API_BASE_URL
+const API_BASE_URL = config.apiBaseUrl
 
 export default function WorkspacePage() {
   const { notebookId } = useParams<{ notebookId: string }>()

infra/envs/dev/terraform.tfvars

@@ -10,7 +10,7 @@ rds_multi_az          = false
 
 task_cpu       = "512"
 task_memory    = "1024"
-desired_count  = 0 # sem imagem publicada no primeiro apply
+desired_count  = 1 # sem imagem publicada no primeiro apply
 container_port = 8080
 
 deletion_protection         = false