Repository navigation
Conversation
… in skim.py and signals.py (Shubhamsaboo#1192)
Owner
|
Thanks for adding language support. The PR says default English behavior is preserved, but a few changes affect the English path too. Please keep these gated behind
Generated by Claude Code |
Author
|
Hi @Shubhamsaboo, Thank you for the review! I've updated the PR with all requested fixes:
Verified both scripts with standard English text and |
Owner
|
Thanks for the update. The
Generated by Claude Code |
Author
|
Hi @Shubhamsaboo, Thanks for the follow-up review! I have addressed all 4 remaining points:
Verified that English behavior and outputs match |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #1192
This PR introduces optional multilingual support via the
--langCLI flag toskim.pyandsignals.pyin thefirst-readerskill, while preserving default English behavior.Key Updates:
skim.py:argparsewith optional--lang(defaults toen).[。!?]and character-based truncation.2026年,95%).signals.py:--langand--jsonsupport withargparse.ensure_ascii=False.Testing:
python3 scripts/skim.py test_draft.md&signals.py --json).python3 scripts/skim.py test_ja.md --lang ja&signals.py --lang ja --json).